chore: better log_effect_tree #17243
Merged
+25
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
|
Contributor
|
Maybe I need to finish my side project, which is basically REPL + autoupdating visualization of the reactivity tree. And even attempt to record its changes. |
dummdidumm
approved these changes
Nov 25, 2025
Member
dummdidumm
left a comment
dummdidumm
left a comment
There was a problem hiding this comment.
untrack suggestion otherwise lgtm 👍
Member
Author
|
lol jinx 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use
log_effect_treea lot when trying to debug why things aren't updating as they should. While using it to wrap my head round #17240 it occurred to me that we could make it a little more useful by printing signal labels and, where applicable, nodes.Before:
After: