Skip to content

Conversation

@adiguba
Copy link
Contributor

@adiguba adiguba commented Nov 29, 2025

Fix issue #16343
And could prevent errors like in this discord message

The state_referenced_locally warning only trigger when referencing $state/$derived, but not when referencing $props.
This could break the reactivity :

<script lang="ts">
    let { data } = $props();

    // `data.users` is reactive, but `users` will always contain the initial value
    let users = $state(data.users); // no warning
}

This PR will add a state_referenced_locally in this case.

Notes :

  • I didn't make a new test, but updated the existing one. I can change that if needed.
  • Sometime we may want to get the initial value.
    Perhaps we should document the // svelte-ignore state_referenced_locally comment in this case

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint
    (there a warning on an existing and not-modified file)

@changeset-bot
Copy link

changeset-bot bot commented Nov 29, 2025

🦋 Changeset detected

Latest commit: 42dc486

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@17266

Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think this is a much-needed change

@Rich-Harris Rich-Harris merged commit 570f649 into sveltejs:main Nov 29, 2025
14 checks passed
@github-actions github-actions bot mentioned this pull request Nov 29, 2025
@frederikhors
Copy link

How do you fix that case, @adiguba? With $derived()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants