fix: add props to state_referenced_locally#17266
Merged
Rich-Harris merged 2 commits intosveltejs:mainfrom Nov 29, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 42dc486 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Rich-Harris
approved these changes
Nov 29, 2025
Member
Rich-Harris
left a comment
There was a problem hiding this comment.
Nice! I think this is a much-needed change
|
How do you fix that case, @adiguba? With |
kmendell
added a commit
to getarcaneapp/arcane
that referenced
this pull request
Dec 2, 2025
… svelte-check warnings (#1042)
Open
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #16343
And could prevent errors like in this discord message
The state_referenced_locally warning only trigger when referencing $state/$derived, but not when referencing $props.
This could break the reactivity :
This PR will add a state_referenced_locally in this case.
Notes :
Perhaps we should document the
// svelte-ignore state_referenced_locallycomment in this caseBefore submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint(there a warning on an existing and not-modified file)