fix: don't issue a11y warning for video without captions if it has no src#17311
Merged
paoloricciuti merged 2 commits intomainfrom Dec 5, 2025
Merged
fix: don't issue a11y warning for video without captions if it has no src#17311paoloricciuti merged 2 commits intomainfrom
src#17311paoloricciuti merged 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 0029c5d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
paoloricciuti
approved these changes
Dec 5, 2025
Member
paoloricciuti
left a comment
There was a problem hiding this comment.
I'm gonna approve in case you need a thumb for it but maybe we should wait for an a11y expert for this?
cc @geoffrich
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
<video>without a child<track kind="captions">element yields an a11y warning. This is unhelpful in the case where, for example, the element in question is being used to show aMediaStream(e.g. the user's webcam).We could debate whether the warning should be relaxed altogether (not every video needs captions) but I think there's probably value in keeping it and requiring the developer to be explicit about that fact when there's a
src. But when there is nosrc, the warning feels misplaced.Accompanies #17310
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint