Skip to content

fix: don't issue a11y warning for video without captions if it has no src #17311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paoloricciuti merged 2 commits into from
Dec 5, 2025
+22 −8
Merged

fix: don't issue a11y warning for video without captions if it has no src #17311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49a267e
fix: don't issue a11y warning for video without captions if it has no
Rich-Harris Dec 5, 2025
0029c5d
update test
Rich-Harris Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dark-buckets-hang.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: don't issue a11y warning for `<video>` without captions if it has no `src`
8 changes: 8 additions & 0 deletions packages/svelte/src/compiler/phases/2-analyze/visitors/shared/a11y/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,9 +486,17 @@ export function check_element(node, context) {
case 'video': {
const aria_hidden_attribute = attribute_map.get('aria-hidden');
const aria_hidden_exist = aria_hidden_attribute && get_static_value(aria_hidden_attribute);

if (attribute_map.has('muted') || aria_hidden_exist === 'true' || has_spread) {
return;
}

if (!attribute_map.has('src')) {
// don't warn about missing captions if `<video>` has no `src` —
// could e.g. be playing a MediaStream
return;
}

let has_caption = false;
const track = /** @type {AST.RegularElement | undefined} */ (
node.fragment.nodes.find((i) => i.type === 'RegularElement' && i.name === 'track')
Expand Down
11 changes: 6 additions & 5 deletions packages/svelte/tests/validator/samples/a11y-media-has-caption/input.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<video><track kind="captions"/></video>
<video></video>
<video><track /></video>
<video src="x"><track kind="captions"/></video>
<video src="x"></video>
<video src="x"><track /></video>
<audio></audio>
<video aria-hidden="true"></video>
<video aria-hidden="false"></video>
<video src="x" aria-hidden="true"></video>
<video src="x" aria-hidden="false"></video>
<video></video> <!-- no src -->
6 changes: 3 additions & 3 deletions packages/svelte/tests/validator/samples/a11y-media-has-caption/warnings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{
"code": "a11y_media_has_caption",
"end": {
"column": 15,
"column": 23,
"line": 2
},
"message": "`<video>` elements must have a `<track kind=\"captions\">`",
Expand All @@ -14,7 +14,7 @@
{
"code": "a11y_media_has_caption",
"end": {
"column": 24,
"column": 32,
"line": 3
},
"message": "`<video>` elements must have a `<track kind=\"captions\">`",
Expand All @@ -26,7 +26,7 @@
{
"code": "a11y_media_has_caption",
"end": {
"column": 35,
"column": 43,
"line": 6
},
"message": "`<video>` elements must have a `<track kind=\"captions\">`",
Expand Down
Loading