fix: skip static optimisation for stateless deriveds after await #17389
+24
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For expressions that we know will not change, we set text content during component initialisation rather than in an effect:
This fails if the right-hand side isn't known at initialisation time, and in the case of a derived that comes after an
awaitbut has no dynamic dependencies......it results in
$.get(undefined), since the derived isn't created until after initialisation. This fixes it.It's a real edge case, but it's one I ran into while looking into #17271 — will self-merge once green to unblock further exploration.
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint