[docs] Fix the speed of the typewriter example to scale correctly #6568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
First time contributing to the project - not sure how important this is but it feels like an improvement to me. Please let me know if there's anything I should change for the PR to be merged. |
tanhauhau
reviewed
Aug 3, 2021
site/content/examples/09-transitions/04-custom-js-transitions/App.svelte
Outdated
Show resolved
Hide resolved
Member
|
this PR would need to be rebased |
Contributor
Author
Thanks for the heads up, I updated it. |
benmccann
reviewed
Aug 28, 2021
benmccann
reviewed
Aug 28, 2021
site/content/tutorial/10-transitions/05-custom-js-transitions/app-b/App.svelte
Outdated
Show resolved
Hide resolved
benmccann
reviewed
Aug 28, 2021
site/content/tutorial/10-transitions/05-custom-js-transitions/text.md
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous code, using a higher value for
speedcaused the typewriter effect to happen slower.This PR changes this function to implement a more intuitive behavior: a higher value for speed causes it to type quicker. Additionally, I was testing the
outtransition and was surprised it worked out of the box, so I included it in the examples.Demonstration
Previously
svelte_example_original.mp4
After this PR
svelte_example_pr.mp4