Skip to content

Conversation

@Lootwig
Copy link

@Lootwig Lootwig commented May 17, 2023

Clarify onDestroy behavior for async onMount callbacks.

Fixes #4927.

Clarify onDestroy behavior for async onMount callbacks
@vercel
Copy link

vercel bot commented May 17, 2023

@Lootwig is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented May 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-dev-2 ❌ Failed (Inspect) May 17, 2023 2:30pm

@PuruVJ
Copy link
Collaborator

PuruVJ commented Jul 17, 2023

Could you resolve the merge conflicts? The content has moved from site/content to documentation now

@benmccann
Copy link
Member

Hi @Lootwig. Are you still interested in pursuing this PR? If so, the merge conflicts will need to be addressed

@Lootwig
Copy link
Author

Lootwig commented Oct 29, 2023

hey @benmccann,
nevermind then, seems to be enough of an edge case to discard

@Lootwig Lootwig closed this Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

destroy function returned from onMount is not called if onMount is passed an async function

3 participants