docs: better clarify not to compute state in $effect
#9940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kinglouie
reviewed
Dec 18, 2023
sites/svelte-5-preview/src/routes/docs/content/01-api/02-runes.md
Outdated
Show resolved
Hide resolved
benmccann
commented
Dec 20, 2023
sites/svelte-5-preview/src/routes/docs/content/01-api/02-runes.md
Outdated
Show resolved
Hide resolved
Rich-Harris
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired both by the recent Reddit post and a comment on Discord
It may have been unclear what "it's" was referring to (
$effector$:). Also, be clearer about$:vs$:{}. And we should be clearer about when not to use effectFinally, you can't just swap it in for
onMount