This PR adds comprehensive unit test coverage for the TickX and TickY mark components, which were previously missing test coverage. ## Changes Made ### Test Files Added - `src/tests/tickX.test.svelte` - Test wrapper component for TickX mark - `src/tests/tickX.test.ts` - Complete test suite for TickX functionality (8 tests) - `src/tests/tickY.test.svelte` - Test wrapper component for TickY mark - `src/tests/tickY.test.ts` - Complete test suite for TickY functionality (8 tests) ### Test Coverage The new tests comprehensively cover all major functionality of both marks: **Core Functionality:** - Basic tick rendering with SVG line elements - Custom tick length configuration - Proper positioning based on x/y channel data - Stroke styling (color and opacity) **Data Handling:** - Filtering of invalid data (null/undefined values) - Empty data array handling - dx/dy positioning offsets **Scale Integration:** - Band scale support with proper positioning - Different scale types and their behaviors - Transform attribute verification ### Example Test Case ```javascript it('renders ticks with basic props', () => { const { container } = render(TickXTest, { props: { plotArgs: {}, tickArgs: { data: testData, x: 'x' } } }); const ticks = container.querySelectorAll('g.tick-x > line'); expect(ticks.length).toBe(3); ticks.forEach(tick => { expect(tick.tagName).toBe('line'); expect(tick.getAttribute('y1')).not.toBeNull(); expect(tick.getAttribute('y2')).not.toBeNull(); }); }); ``` ## Quality Assurance - All 16 new tests pass successfully - Full existing test suite (279 tests) continues to pass - Code follows project formatting standards (Prettier) - Passes all linting checks - Project builds successfully - Tests follow established patterns from other mark components The TickX and TickY marks now have test coverage that matches the quality and scope of other mark components in the SveltePlot library, ensuring reliability and preventing regressions. Fixes #174. > [!WARNING] > > <details> > <summary>Firewall rules blocked me from connecting to one or more addresses (expand for details)</summary> > > #### I tried to connect to the following addresses, but was blocked by firewall rules: > > - `googlechromelabs.github.io` > - Triggering command: `node install.mjs` (dns block) > - `https://storage.googleapis.com/chrome-for-testing-public/140.0.7339.80/linux64/chrome-headless-shell-linux64.zip` > - Triggering command: `node install.mjs` (http block) > > If you need me to access, download, or install something from one of these locations, you can either: > > - Configure [Actions setup steps](https://gh.io/copilot/actions-setup-steps) to set up my environment, which run before the firewall is enabled > - Add the appropriate URLs or hosts to the custom allowlist in this repository's [Copilot coding agent settings](https://github.com/svelteplot/svelteplot/settings/copilot/coding_agent) (admins only) > > </details>  --- ✨ Let Copilot coding agent [set things up for you](https://github.com/svelteplot/svelteplot/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: gka <617518+gka@users.noreply.github.com> Co-authored-by: gka <gka@users.noreply.github.com>

Uh oh!

Add unit tests for TickX/Y marks #174

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions