feat: pass ticks array to tickFormat function #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-252
# or install the specific version
npm install svelteplot@0.5.2-pr-252.0 |
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the tickFormat function signature for axis components to accept a third parameter containing the complete array of tick values. This enables custom formatting logic that depends on the full set of ticks, such as adding a unit label only to the last tick.
Key Changes:
- Updated
tickFormatfunction signature to accept(d, i, ticks)instead of(d, i)for both X and Y axes - Added comprehensive test coverage for the new parameter
- Created an example demonstrating unit label formatting on the last tick
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/marks/helpers/BaseAxisX.svelte | Updated tickFormat signature and invocation to pass ticks array |
| src/lib/marks/helpers/BaseAxisY.svelte | Updated tickFormat signature and invocation to pass ticks array |
| src/tests/axisX.test.ts | Added test verifying ticks array is passed to tickFormat |
| src/tests/axisY.test.ts | Added test verifying ticks array is passed to tickFormat |
| src/routes/examples/axis/unit-tick.svelte | Added example demonstrating unit label on last tick |
| static/examples/axis/unit-tick.png | Screenshot for light theme example |
| static/examples/axis/unit-tick.dark.png | Screenshot for dark theme example |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request passes the ticks array to the
tickFormatfunction. This allows for more context-aware formatting, such as adding units only to the last tick. The changes are validated with new tests and demonstrated in an example.