feat: add gradient helpers LinearGradientX and LinearGradientY #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds first-class gradient helpers to SveltePlot, refactors canvas color resolution, and updates documentation and navigation.
- Introduce
LinearGradientXandLinearGradientYSvelte components and export them in the public API - Consolidate color‐and‐gradient parsing into a reusable
resolveColorhelper for canvas marks - Update docs pages, code examples, and sidebar entries for gradient features
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/marks/helpers/LinearGradientX.svelte | New horizontal gradient helper |
| src/lib/marks/helpers/LinearGradientY.svelte | New vertical gradient helper |
| src/lib/marks/helpers/canvas.ts | Added resolveColor to parse and apply SVG gradients in canvas |
| src/lib/marks/helpers/LineCanvas.svelte | Refactored to use resolveColor, removed inline color logic |
| src/lib/marks/helpers/DotCanvas.svelte | Refactored to use resolveColor for dot fill/stroke |
| src/lib/index.ts | Export gradient helpers |
| src/routes/features/gradients/+page.ts | Load datasets for gradients feature |
| src/routes/features/gradients/+page.md | Added documentation for LinearGradientX and LinearGradientY |
| src/routes/marks/line/+page.md | Example usage for gradient lines |
| config/sidebar.ts | Added “Gradients” entry to the sidebar |
Comments suppressed due to low confidence (1)
src/lib/marks/helpers/LinearGradientX.svelte:1
- [nitpick] Consider adding unit or integration tests for the new gradient helpers to verify that data-to-offset mapping and rendering behave as expected.
<script lang="ts">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While SveltePlot allows you to use any SVG gradients, you can also make use of the LinearGradientX and LinearGradientY helpers, which allow mapping data to gradient stops.
https://deploy-preview-42--svelteplot.netlify.app/features/gradients