fix: properly reset ephemeral state in case of error#170
Merged
svenjacobs merged 1 commit intomainfrom Sep 5, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where ephemeral flow state wasn't properly reset to null when an error occurred during response handling in the authentication flow.
- Introduces proper state finalization using
AuthFlowStateFinalizerin error scenarios - Adds comprehensive test coverage for the
AuthFlowUserAgentResponseHandlerclass - Refactors test utilities to support better test setup and reusability
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| AuthFlowUserAgentResponseHandler.kt | Fixes error handling to properly reset ephemeral state using AuthFlowStateFinalizer |
| AuthFlowUserAgentResponseHandlerTest.kt | Adds new test file with comprehensive coverage for response handler scenarios |
| LokksmithTest.kt | Refactors test utilities to be reusable across test files |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.../src/commonMain/kotlin/dev/lokksmith/client/request/flow/AuthFlowUserAgentResponseHandler.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ephemeral flow state wasn't properly resetted to
nullin case an error occurred during response handling.