feat: add support for custom scopes (#262)#263
Merged
svenjacobs merged 4 commits intosvenjacobs:mainfrom Jan 26, 2026
Merged
Conversation
svenjacobs
requested changes
Jan 25, 2026
lib/lokksmith-core/src/commonMain/kotlin/dev/lokksmith/client/request/parameter/Scope.kt
Outdated
Show resolved
Hide resolved
Owner
|
Can you please fix the code formatting with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses #262 by refactoring the
Scopeimplementation to support arbitrary scope strings.The previous
enum classwas too restrictive for modern OIDC/OAuth2 requirements, where custom API scopes (e.g.,api://my-custom-scope) are frequently necessary. Moving to a sealed class keeps the standard OIDC scopes easy to use while allowing for custom scope strings.Changes
Scope: Converted from anenumto asealed class.Scope.Custom(value: String)to support arbitrary scope strings.