Suppress auto-popup of Dialog_NamePlayerGravship in MP#1
Closed
Suppress auto-popup of Dialog_NamePlayerGravship in MP#1
Conversation
4 tasks
Building_GravEngine.UpdateSubstructureIfNeeded creates this dialog during tick when validSubstructure.Count > 90. In MP both clients independently create and submit it, causing a desync. Set the [Unsaved] haveShownNameDialog flag in a prefix so the auto-popup condition is never met. Manual renaming via inspect tab (IRenameable) is already synced generically by SyncMethods. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sviyh
force-pushed
the
fix/suppress-gravship-naming-dialog
branch
from
2779e1e to
8310f23
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Building_GravEngine.UpdateSubstructureIfNeededsetshaveShownNameDialog = truein MP, preventing the auto-popup ofDialog_NamePlayerGravshipduring tickIRenameable) is already synced generically bySyncMethodsFieldRefto avoid per-call reflection overhead (this method runs from property getters hit many times per frame)Test plan
🤖 Generated with Claude Code