chore: bump all#219
Open
SilasPeters wants to merge 1 commit intodevelopmentfrom
Open
Conversation
Member
Author
|
Please test if it works on your machine as well. Are there any packages which we expect to fail if it got updated? |
Member
|
alleen de lockfile is gechanged, wat is de commitcrowd best practice op package.json? doen we ^, ~, of hard version pinning? En wat willen we hier? |
Member
|
ik vind zelf denk ik ^ voor packages vaak fine |
Member
|
mits we de lockfile strict gebruiken in de pipeline (npm ci) |
Member
Author
|
Oh right only the lock changed. I just did 'npm upgrade' or something that's all. I don't have a preference for ^ or ~ |
Member
|
we should probably check wether or not there are major changes. I do not know if npm upgrade takes into account major changes, or just the minor and patch from ^ (or only the patch from ~) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Worked on my
machinedevcontainer