feat: add support for parse errors #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the underlying json-ast parser fails to parse the document, it will throw an error. This error is translated into ApiDOM Annotation and embedded into ParserResult. Special case of failure is when there is no parsing error but the shape of the data is unexpected for the parser. So this case is more an unexpected failure. This case will be handled in future by validator, that runs before the mapping visitors kics in. Closes #4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the underlying json-ast parser fails to parse the document, it will throw an error.
This error is translated into ApiDOM Annotation and embedded into ParserResult.
Special case of failure is when there is no parsing error but the shape of the data
is unexpected for the parser. So this case is more an unexpected failure. This case
will be handled in future by validator, that runs before the mapping visitors kics in.
Closes #4