[JavaScript] Invalid date parsing for all browsers.

[Danielku15]

Description

We are using the JavaScript code generator in combination with browserify. It brings us some benefits to have some "static code"-generation for JavaScript. The problem is that the date parsing function is not working for all browsers. Not all browsers have proper ISO-8601 parsing capabilities. Only Chrome parses the dates correctly.

swagger-codegen/modules/swagger-codegen/src/main/resources/Javascript/ApiClient.mustache

Line 413 in 8f258b9

{{/emitJSDoc}} exports.parseDate = function(str) {

Swagger-codegen version

2.1.6

Swagger declaration file content or url

Any date-time parameter. e.g. http://petstore.swagger.io/#!/store/getOrderById

Command line used for generation

java -jar swagger-codegen.jar generate -i http://petstore.swagger.io/v2/swagger.json -l JavaScript - o jsclient 
cd jsclient
npm install
cd ..
browserify jsclient\src\index.js -o client.js --standalone PetStoreClient

swagger-codegen/samples/client/petstore/javascript/src/ApiClient.js

Line 397 in 8f258b9

/**

Steps to reproduce

1. Generate the client
2. Use the client.js in the browser to make a call to getOrderById
3. Inspect the shipDate

Related issues

No

Suggest a Fix

One solution could be to use moment.js to parse the date. An other solution might be to parse the ISO date manually with some regex.
https://www.safaribooksonline.com/library/view/javascript-cookbook/9781449390211/ch03s05.html

Considering only IE9 and higher all browsers support out of the box ISO8601 parsing. This means even new Date(str) would work.

[wing328]

@Danielku15 thanks for reporting the issue with details and suggesting a few solutions to tackle the problem

From what I read (http://stackoverflow.com/questions/5802461/javascript-which-browsers-support-parsing-of-iso-8601-date-string-with-date-par), seems like the implementation is not consistent across browsers and therefore I prefer moment.js.

May I know if you've cycle to contribute the enhancements?

Ref: https://github.com/swagger-api/swagger-codegen/blob/master/CONTRIBUTING.md

[Danielku15]

ISO8601 date parsing became part of browsers in ECMAScript version 5. Considering this source and take the Date.prototype.toISOString as indicactor on ISO date parsing support, all browser should support it with normal new Date("str") instead of the T removal which breaks the parsing on most of the browsers.

http://www.ecma-international.org/ecma-262/5.1/#sec-15.9.1.15
http://caniuse.com/#feat=es5
http://kangax.github.io/compat-table/es5/
http://stackoverflow.com/questions/10005374/ecmascript-5-date-parse-results-for-iso-8601-test-cases

[wing328]

@Danielku15 if you feel more comfortable with the new Date("str") solution, please go with that.

[wing328]

@Danielku15 may I know if you're working on this particular issue? Do you need any help from the community?

[YetAnotherMinion]

@Danielku15 If you are not working on this I'd like to go ahead and take a crack at it.