Add support for optional queryParams. #4308
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove parameterToString from exports (end user should not need this function). Add comma back to localVarHttpContentTypes and localVarHttpHeaderAccepts as it refuses to compile without it. Rewrite ParameterToString to handle other slice types other than just string.
3 tasks
|
See my comment here -- wouldn't it be better to use pointers for optional types, to allow passing in nil for unspecified values, while retaining compile-time type checking? |
|
I believe this can be closed as #4415 has been merged into 2.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
Few Golang fixes.
Add support for optional queryParams.
Remove parameterToString from exports (end user should not need this function).
Add comma back to localVarHttpContentTypes and localVarHttpHeaderAccepts as it refuses to compile without it.
Rewrite ParameterToString to handle other slice types other than just string.