[Go] Add optional parameters to go client using map[string]interface{} #4415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor tests to new API and add concurrency test.
The pet-store does not create this scenario.
This was referenced Dec 16, 2016
wing328
reviewed
Dec 20, 2016
|
|
||
| Note: Optional parameters are passed through a map[string]interface{} | ||
| {{/hasOptionalParams}} | ||
|
|
There was a problem hiding this comment.
I think we can do it one step further by providing code samples similar to what we've done for other languages (e.g. C#, Python, etc)
|
@antihax thanks for the PR. The change looks very good 👍 |
3 tasks
wing328
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
Add optional parameters to go client using map[string]interface{}
Add concurrency test.