Skip to content

[Swift3] remove XCode warnings#6298

Merged
wing328 merged 5 commits intoswagger-api:masterfrom
ahmet8282:swift3-xcodewarnings
Aug 13, 2017
Merged

[Swift3] remove XCode warnings#6298
wing328 merged 5 commits intoswagger-api:masterfrom
ahmet8282:swift3-xcodewarnings

Conversation

@ahmet8282
Copy link
Copy Markdown
Contributor

This fixes #6258 for Xcode 8.3.3

@wing328
Copy link
Copy Markdown
Contributor

wing328 commented Aug 12, 2017

@jaz-ah
Copy link
Copy Markdown
Contributor

jaz-ah commented Aug 13, 2017

+1 looks fine @wing328

@wing328 wing328 merged commit da4fe86 into swagger-api:master Aug 13, 2017
@wing328
Copy link
Copy Markdown
Contributor

wing328 commented Aug 13, 2017

@jaz-ah Thanks for reviewing the change.

@ahmettahasakar thanks for the PR. When you've time, I wonder if you can make similar enhancement to the swift4 templates

cc @ehyche

@wing328 wing328 changed the title Swift3 xcodewarnings [Swift3] remove XCode warnings Aug 13, 2017
@ahmet8282
Copy link
Copy Markdown
Contributor Author

@wing328 I don't seem to see the same warnings with Xcode 9.0 beta. I see other warnings about @objc

The use of Swift 3 @objc inference in Swift 4 mode is deprecated. Please address deprecated @objc inference warnings, test your code with “Use of deprecated Swift 3 @objc inference” logging enabled, and disable Swift 3 @objc inference.

What should I do?

@ehyche
Copy link
Copy Markdown
Contributor

ehyche commented Sep 11, 2017

@ahmettahasakar : agreed that we don't see the same compiler warnings in swift4 generated code. However, for the issue you noticed above regarding @objc infererence, I have fixed that in this PR:

#6468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Swift 3 Warnings

4 participants