Skip to content

Conversation

@ackintosh
Copy link
Contributor

@ackintosh ackintosh commented Dec 9, 2017

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This PR improves the disabled test code in StoreApiTest.

@ackintosh
Copy link
Contributor Author

@wing328 wing328 added this to the v2.3.0 milestone Dec 9, 2017
@wing328 wing328 merged commit cfa5a55 into swagger-api:master Dec 9, 2017
Gingonic pushed a commit to wirelane/swagger-codegen that referenced this pull request Dec 9, 2017
* Move the test code to the appropriate test case

* currently, InvalidArgumentException will be thrown

* Remove unnecessary tests at this time

* Unify into single quotes
@ackintosh ackintosh deleted the improve-store-api-test branch December 10, 2017 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants