Skip to content

Implemented thread safe storage of SessionManager for Alamofire #8392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implemented thread safe storage of SessionManager for Alamofire #8392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions modules/swagger-codegen/src/main/resources/swift4/AlamofireImplementations.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ class AlamofireRequestBuilderFactory: RequestBuilderFactory {

// Store manager to retain its reference
private var managerStore: [String: Alamofire.SessionManager] = [:]
// Concurrent queue to save sessionmanagers thread safe
private let concurrentQueue = DispatchQueue(label: "concurrentQueue", attributes: .concurrent)

open class AlamofireRequestBuilder<T>: RequestBuilder<T> {
required public init(method: String, URLString: String, parameters: [String : Any]?, isBody: Bool, headers: [String : String] = [:]) {
Expand Down Expand Up @@ -58,7 +60,9 @@ open class AlamofireRequestBuilder<T>: RequestBuilder<T> {
let managerId:String = UUID().uuidString
// Create a new manager for each request to customize its request header
let manager = createSessionManager()
managerStore[managerId] = manager
concurrentQueue.async(flags: .barrier) {
managerStore[managerId] = manager
}

let encoding:ParameterEncoding = isBody ? JSONDataEncoding() : URLEncoding()

Expand Down Expand Up @@ -112,7 +116,9 @@ open class AlamofireRequestBuilder<T>: RequestBuilder<T> {
}

let cleanupRequest = {
_ = managerStore.removeValue(forKey: managerId)
concurrentQueue.async(flags: .barrier) {
_ = managerStore.removeValue(forKey: managerId)
}
}

let validatedRequest = request.validate()
Expand Down Expand Up @@ -314,7 +320,9 @@ open class AlamofireDecodableRequestBuilder<T:Decodable>: AlamofireRequestBuilde
}

let cleanupRequest = {
_ = managerStore.removeValue(forKey: managerId)
concurrentQueue.async(flags: .barrier) {
_ = managerStore.removeValue(forKey: managerId)
}
}

let validatedRequest = request.validate()
Expand Down