Skip to content

Inner properties may have XML declared#2313

Closed
mobreza wants to merge 2 commits intoswagger-api:masterfrom
mobreza:read-xml-definition
Closed

Inner properties may have XML declared#2313
mobreza wants to merge 2 commits intoswagger-api:masterfrom
mobreza:read-xml-definition

Conversation

@mobreza
Copy link
Contributor

@mobreza mobreza commented Jul 15, 2017

Swagger specification allows for "xml" element defined on the "items" of an array:

When defined within the Items Object (items), it will affect the name of the individual XML elements within the list. When defined alongside type being array (outside the items), it will affect the wrapping element and only if wrapped is true. If wrapped is false, it will be ignored.

For ArrayProperty, the detailNode = node.get("items") is read, but the "xml" declaration on that element is not set. This PR moves to property.setXml(getXml(node)); to the propertyFromNode(JsonNode node) method.

@mobreza
Copy link
Contributor Author

mobreza commented Jul 17, 2017

See #2316

@zregvart
Copy link

There is now a pull request rebased against the master in #2674

@frantuma
Copy link
Contributor

included and replaced by #2688

@frantuma frantuma closed this Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants