Inner properties may have XML declared#2313
Closed
mobreza wants to merge 2 commits intoswagger-api:masterfrom
mobreza:read-xml-definition
Closed
Inner properties may have XML declared#2313mobreza wants to merge 2 commits intoswagger-api:masterfrom mobreza:read-xml-definition
mobreza wants to merge 2 commits intoswagger-api:masterfrom
mobreza:read-xml-definition
Conversation
Contributor
Author
|
See #2316 |
This was referenced Jul 23, 2017
|
There is now a pull request rebased against the master in #2674 |
Contributor
|
included and replaced by #2688 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swagger specification allows for "xml" element defined on the "items" of an array:
For
ArrayProperty, thedetailNode = node.get("items")is read, but the "xml" declaration on that element is not set. This PR moves toproperty.setXml(getXml(node));to thepropertyFromNode(JsonNode node)method.