jackson 2.9.1#2342
jackson 2.9.1#2342pjfanning wants to merge 5 commits intoswagger-api:masterfrom pjfanning:jackson-2.9.0
Conversation
deki
left a comment
deki
left a comment
There was a problem hiding this comment.
Great that you updated it. Currently swagger fails when Jackson 2.9.0 is on classpath. I don't understand why the Jackson guys couldn't deprecate the annotated() method first and remove it later.
pom.xml
Outdated
| <surefire-version>2.18.1</surefire-version> | ||
| <maven-plugin-version>1.0.0</maven-plugin-version> | ||
| <commons-lang-version>3.2.1</commons-lang-version> | ||
| <commons-lang-version>3.5</commons-lang-version> |
| if (member != null && !ignore(member, xmlAccessorTypeAnnotation, propName, propertiesToIgnore)) { | ||
| List<Annotation> annotationList = new ArrayList<Annotation>(); | ||
| for (Annotation a : member.annotations()) { | ||
| for (Annotation a : member.getAllAnnotations().annotations()) { |
| } else { | ||
| return context.resolveProperty(propType, | ||
| Iterables.toArray(propMember.annotations(), Annotation.class)); | ||
| Iterables.toArray(propMember.getAllAnnotations().annotations(), Annotation.class)); |
| paramType = field.getRawType(); | ||
|
|
||
| for (final Annotation fieldAnnotation : field.annotations()) { | ||
| for (final Annotation fieldAnnotation : field.getAllAnnotations().annotations()) { |
| } | ||
|
|
||
| for (final Annotation fieldAnnotation : setter.annotations()) { | ||
| for (final Annotation fieldAnnotation : setter.getAllAnnotations().annotations()) { |
| } | ||
|
|
||
| for (final Annotation fieldAnnotation : getter.annotations()) { | ||
| for (final Annotation fieldAnnotation : getter.getAllAnnotations().annotations()) { |
|
@deki thanks for reviewing - I have pushed a new commit to address the issues you raised |
|
+1 for this PR. We just ran into this with a wonderful NoSuchMethodError |
|
+1. Please never break binary compatibility in a minor release and create jar hell for the rest of us. If you do want to break BC, do so in a major release along with a package name and Maven coordinate change. That the only same way to go. |
|
I was unaware of FasterXML/jackson-databind@bf451c0 when I added this PR. I just assumed the annoations in jackson-databind had been deprecated. |
|
+1. I'm also in jar hell because of the jackson-databind mess, and unfortunately 2.9.0 already sneaked in as a dependendency to my project. Any rough estimates on when this might be merged & released? |
|
+1. Jar hell for me too |
|
I created a PR for Jackson to reintroduce the method for 2.9.1 release for the meantime: FasterXML/jackson-databind#1752 |
|
Jackson 2.9.1 was released in the meantime. My fix is included. So in case you are in jar hell, you can solve it now. |
|
This is already updated in the 2.0 branch |
6 participants
No description provided.