Skip to content

feat: update @codingame/monaco-vscode-api to version 31.0.1#5777

Merged
glowcloud merged 3 commits into
mainfrom
feat/oss-1025-update-monaco
May 11, 2026
Merged

feat: update @codingame/monaco-vscode-api to version 31.0.1#5777
glowcloud merged 3 commits into
mainfrom
feat/oss-1025-update-monaco

Conversation

@glowcloud
Copy link
Copy Markdown
Contributor

This PR updates VSCode and Monaco Editor to @codingame/monaco-vscode-api version 31.0.1.

@glowcloud glowcloud self-assigned this May 8, 2026
@glowcloud glowcloud added the dependencies Pull requests that update a dependency file label May 8, 2026
@glowcloud glowcloud marked this pull request as ready for review May 8, 2026 12:49
Comment thread src/plugins/editor-monaco-language-apidom/language/apidom.worker.js
@robert-hebel-sb
Copy link
Copy Markdown
Contributor

Code review

Found 2 issues:

  1. WorkerManager.getProxy() is not awaited — in @codingame/monaco-vscode-api v31, MonacoWebWorker.getProxy() now returns Promise<T> instead of T. Assigning the result without await stores a Promise in this.#client, so all downstream language service calls (validation, completions, hover) will fail with a TypeError at runtime. The fix is this.#client = await this.#worker.getProxy();

});
this.#client = this.#worker.getProxy();
}
return this.#client;

  1. Stale JSDoc comment — the file-level comment still says "dispatch paste events to the editor's textarea" but the PR changed the selector to .native-edit-context

*
* The tests use Monaco's API directly to dispatch paste events to the editor's textarea,
* which reliably triggers the paste event handler in automated testing.
*

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

@glowcloud
Copy link
Copy Markdown
Contributor Author

  1. WorkerManager.getProxy() is not awaited — in @codingame/monaco-vscode-api v31, MonacoWebWorker.getProxy() now returns Promise<T> instead of T. Assigning the result without await stores a Promise in this.#client, so all downstream language service calls (validation, completions, hover) will fail with a TypeError at runtime. The fix is this.#client = await this.#worker.getProxy();

});
this.#client = this.#worker.getProxy();
}
return this.#client;

AFAIK this has always been the case

@robert-hebel-sb
Copy link
Copy Markdown
Contributor

this.#worker.getProxy();

truu, Claude gaslighted me again 😞

@glowcloud glowcloud merged commit 2ce6934 into main May 11, 2026
5 checks passed
@glowcloud glowcloud deleted the feat/oss-1025-update-monaco branch May 11, 2026 11:00
swagger-bot pushed a commit that referenced this pull request May 12, 2026
# [5.4.0](v5.3.8...v5.4.0) (2026-05-12)

### Bug Fixes

* **build:** fix build:bundle:umd command ([#5782](#5782)) ([b19a569](b19a569))

### Features

* update @codingame/monaco-vscode-api to version 31.0.1 ([#5777](#5777)) ([2ce6934](2ce6934))
@swagger-bot
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 5.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants