Bad expression in lib/types/model.js

[pip25]

This part:

if (_.isUndefined(model) || _.indexOf([undefined, 'array', 'object'], model.definition.type) === -1) {
                // Use referenced schema
                cProperty = helpers.resolveSchema(model.definition);
}

is obviously incorrect, since if model is undefined, then model.definition cannot be evaluated.
Simply negating the expression causes some sort of infinite loop, however, freezing the browser, so the issue is probably more complicated than that.
This issue currently breaks Swagger-UI for me.

[webron]

Not saying that doesn't need to be fixed, but is your Swagger definition correct? Can you share it?

[pip25]

I'm not in the position to share it, but my Swagger definition is working just fine with earlier versions of Swagger-UI. By the way, the infinite loop disappears if I comment out the whole

    if (!_.isUndefined(cProperty.$ref)) {
              model = models[helpers.simpleRef(cProperty.$ref)];

              if (_.isUndefined(model) || _.indexOf([undefined, 'array', 'object'], model.definition.type) === -1) {
                // Use referenced schema
                cProperty = helpers.resolveSchema(model.definition);
              }
      }

part. Then the UI renders fine.

[webron]

By the way, this is tested with which version?

[pip25]

Latest of the develop_2.0 branch of Swagger UI, which depends on Swagger Client 2.1.4-M2. I was trying to test the fix for another issue (swagger-api/swagger-ui#1139) when I ran into this one.

[fehguy]

This is because you have a missing model reference in your spec, which is an issue. The client crashing is a different matter, but it should be fixed here: 75ac559

You can test this change by pulling swagger-js develop_2.0 branch, running npm link in that project, then npm link swagger-client in swagger-ui, develop_2.0 branch. Then run gulp and you'll have the latest swagger-js and swagger-ui.

[whitlockjc]

Should probably be: if (!_.isUndefined(model) && _.indexOf([undefined, 'array', 'object'], model.definition.type) === -1) { We only want to use the referenced model when it exists and its type is what we call a model.

[pip25]

Yes, I can confirm that the issue is no longer present in the current swagger-js develop_2.0 branch HEAD. Thank you. :)