URL encode parameters for OpenApiSpec 3

[artemyarulin]

URL encode parameters for OpenApiSpec 3

Description

Fixes this issue in swagger-ui swagger-api/swagger-ui#4025

Motivation and Context

I guess it was disabled by accident in #1181 which was about allowing to skip url encode for query params if Paramter.allowReserved is set to true. But specification says clearly:

Determines whether the parameter value SHOULD allow reserved characters, as defined by RFC3986 :/?#[]@!$&'()*+,;= to be included without percent-encoding. This property only applies to parameters with an in value of query. The default value is false.. So it should be applied only to query params and path parameters should use encoding all the time

How Has This Been Tested?

I'm not familiar with your testing strategy, but I've recompiled your library and checked that it works correctly using swagger-ui:

Before:

After:

Types of changes

• No code changes (changes to documentation, CI, metadata, etc)
• Dependency changes (any modification to dependencies in package.json)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[shockey]

Note to self: the fact that changing false to true here didn't break any tests is concerning - may need to add additional unit tests along with this PR

[artemyarulin]

Anything I can do to push it forward? Tests, docs, etc.?

[shockey]

@artemyarulin, yes! I was planning to add some tests myself, but some cases that fail prior to this change would be great, if you're up to the task 😄