Skip to content

Conversation

@shockey
Copy link
Contributor

@shockey shockey commented Sep 9, 2018

Description

This PR reverts part of #1374. While the use of the browser's navigator object is welcome, #1374 also introduced browser global tolerance to our test harness configs, which allowed code that will only work in a browser to slip through.

The changes within should resolve that.

Motivation and Context

Fixes #1382.

How Has This Been Tested?

The configuration changes make the tests effective 😄

Types of changes

  • No code changes (changes to documentation, CI, metadata, etc)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: Use of parameters causes "ReferenceError: navigator is not defined"

1 participant