Skip to content

Conversation

@char0n
Copy link
Contributor

@char0n char0n commented May 14, 2020

Description

Problem was resolved by updating nock library to newest versions
that no longer uses node deprecated API.

Motivation and Context

When running tests, deprecation warning DEP0066 was triggering warning.

https://nodejs.org/api/deprecations.html#deprecations_dep0066_outgoingmessage_prototype_headers_outgoingmessage_prototype_headernames

Types of changes

  • No code changes (changes to documentation, CI, metadata, etc)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

When running tests, deprecation warning DEP0066 was triggering warning.
Problem was resolved by updating nock library to newest versions
that no longer uses node deprecated API.

https://nodejs.org/api/deprecations.html#deprecations_dep0066_outgoingmessage_prototype_headers_outgoingmessage_prototype_headernames
@char0n char0n requested a review from tim-lai May 14, 2020 11:21
@char0n char0n self-assigned this May 14, 2020
@char0n char0n added this to the M2 milestone May 14, 2020
@char0n char0n merged commit c645e56 into master May 15, 2020
@char0n char0n deleted the char0n/test-fix-deprecation-warning branch May 15, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants