Prevent StackOverflowError in ResolverFully#2297
Merged
ewaostrowska merged 2 commits intoswagger-api:masterfrom Apr 15, 2026
Merged
Prevent StackOverflowError in ResolverFully#2297ewaostrowska merged 2 commits intoswagger-api:masterfrom
StackOverflowError in ResolverFully#2297ewaostrowska merged 2 commits intoswagger-api:masterfrom
Conversation
Add guard to resolve just once to prevent loops/stack overflows. Issue swagger-api#1751. Signed-off-by: thc202 <thc202@gmail.com>
3ab57a3 to
936f8c2
Compare
Contributor
|
Hi @thc202, The solution you came up with has covered most of the cases here, but not all. I have introduced in-progress cache as well for that reason. |
daniel-kmiecik
approved these changes
Apr 15, 2026
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add guard to resolve schemas just once to prevent loops/stack overflows.
ResolverFully.resolveSchema()threwjava.lang.StackOverflowErrorwhen parsingOpenAPI documents that contain recursive schema definitions. For example: a schema
whose
additionalProperties.oneOfreferences itself, or a tree-shaped model whoseitemspoints back to the parent type.Two-phase guard:
schemasInProgressresolvedSchemasFix #1751.
Type of Change
Checklist