Skip to content

Conversation

@EtonDoze
Copy link
Contributor

@EtonDoze EtonDoze commented Jan 8, 2018

Fix for issue #620 where allOf fails to process load properties with external $ref
sample:

{
  "allOf": [
    {
      "$ref": "./pet.json"
    },
    {
      "type": "object",
      "properties": {
        "mother": {
          "$ref": "./pet.json"
        }
      }
    }
  ]
}

This PR fixes the issue where pet.json under properties fails to load.

@EtonDoze
Copy link
Contributor Author

EtonDoze commented Jan 9, 2018

Attn: @gracekarina, pls review/merge when u get a chance.

@gracekarina gracekarina self-requested a review January 9, 2018 04:53
@gracekarina
Copy link
Contributor

Thanks @EtonDoze

@gracekarina gracekarina merged commit 42cb599 into swagger-api:master Jan 9, 2018
@EtonDoze
Copy link
Contributor Author

EtonDoze commented Jan 9, 2018

@gracekarina, Thx for the merge. I am really looking forward to use these fixes. When can we expect a new release build with these fixes? What would trigger that process?

@gracekarina
Copy link
Contributor

Hi @EtonDoze, as soon as I have a date I'll let you know. There are a couple more fixes to be included 👍

@EtonDoze
Copy link
Contributor Author

Thx @gracekarina. I'll be happy to contribute if you let me know the pending issues ids slated for next release.

@gracekarina
Copy link
Contributor

@EtonDoze We expect to release by the end of the month. I'll get back about the ID's if I see wont be able to review them all! thanks!

@EtonDoze
Copy link
Contributor Author

thx @gracekarina. Looking forward to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants