Skip to content

refs swagger-api/swagger-core#2492 - remove allEmptyValue from body param and headers #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2018
Merged

refs swagger-api/swagger-core#2492 - remove allEmptyValue from body param and headers #653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...er-parser-v2-converter/src/main/java/io/swagger/v3/parser/converter/SwaggerConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -890,7 +890,9 @@ public Parameter convert(io.swagger.models.parameters.Parameter v2Parameter) {
if (StringUtils.isNotBlank(v2Parameter.getDescription())) {
v3Parameter.setDescription(v2Parameter.getDescription());
}
v3Parameter.setAllowEmptyValue(v2Parameter.getAllowEmptyValue());
if (v2Parameter instanceof SerializableParameter) {
v3Parameter.setAllowEmptyValue(((SerializableParameter)v2Parameter).getAllowEmptyValue());
}
v3Parameter.setIn(v2Parameter.getIn());
v3Parameter.setName(v2Parameter.getName());

Expand Down
13 changes: 5 additions & 8 deletions modules/swagger-parser-v3/src/main/java/io/swagger/v3/parser/util/OpenAPIDeserializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1320,9 +1320,11 @@ public Parameter getParameter(ObjectNode obj, String location, ParseResult resul
parameter.setDeprecated(deprecated);
}

Boolean allowEmptyValue = getBoolean("allowEmptyValue", obj, false, location, result);
if (allowEmptyValue != null) {
parameter.setAllowEmptyValue(allowEmptyValue);
if (parameter instanceof QueryParameter) {
Boolean allowEmptyValue = getBoolean("allowEmptyValue", obj, false, location, result);
if (allowEmptyValue != null) {
parameter.setAllowEmptyValue(allowEmptyValue);
}
}

value = getString("style", obj, false, location, result);
Expand Down Expand Up @@ -1433,11 +1435,6 @@ public Header getHeader(ObjectNode headerNode, String location, ParseResult resu
header.setDeprecated(deprecated);
}

Boolean allowEmptyValue = getBoolean("allowEmptyValue", headerNode, false, location, result);
if (allowEmptyValue != null) {
header.setAllowEmptyValue(allowEmptyValue);
}

Boolean explode = getBoolean("explode", headerNode, false, location, result);
if (explode != null) {
header.setExplode(explode);
Expand Down