Escape $ in curl request bodies and headers
#6245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-lai
suggested changes
Jul 28, 2020
Contributor
tim-lai
left a comment
tim-lai
left a comment
There was a problem hiding this comment.
@harpocrates Thanks for the PR. Change itself looks fine, however, we should have Cypress tests that reflects the fix to #5390.
harpocrates
force-pushed
the
alec/escape-dollar-requests
branch
from
4bc8ac4 to
b71151e
Compare
This address a bug where a `$` character in a request body or header would not be properly escaped in a string in the generated curl command. Fixes swagger-api#5390
harpocrates
force-pushed
the
alec/escape-dollar-requests
branch
from
b71151e to
29593c3
Compare
Contributor
Author
|
@tim-lai It looks like there is already a pretty big Mocha suite to test |
tim-lai
approved these changes
Aug 3, 2020
Contributor
|
@harpocrates Thanks for the update with curlify mocha test. This PR is now merged! Thanks for the contribution! |
harpocrates
added a commit
to harpocrates/swagger-ui
that referenced
this pull request
Sep 1, 2020
In swagger-api#6245 I forgot that calling `replace` with a string as the first argument replaces only the first occurrence of the string. In order to replace all occurrences, we need to use a regex with the global (g) modifier.
17 tasks
harpocrates
added a commit
to harpocrates/swagger-ui
that referenced
this pull request
Sep 10, 2020
In swagger-api#6245 I forgot that calling `replace` with a string as the first argument replaces only the first occurrence of the string. In order to replace all occurrences, we need to use a regex with the global (g) modifier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Escape
$in generated curl commandsDescription
This address a bug where a
$character in a request body or headerwould not be properly escaped in string literals in the generated curl command.
Motivation and Context
We have a REST endpoint which is sending Cypher queries. In particular, our API uses parametrized queries where the dollar sign is critically important (here is a sample of such a query, taken from the link above
MATCH (n:Person) WHERE n.name = $name RETURN n)Fixes #5390
How Has This Been Tested?
Locally checked that the produced curl command now works.
Screenshots (if appropriate):
N/A
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests