Skip to content

Conversation

@geraldglynn
Copy link
Contributor

Description

Parameters Extensions, Response Extensions and Response Links render the key in .map() in React 16.
To prevent this .entrySeq() is used

Motivation and Context

Keys in .map() are getting rendered to DOM when using React 16

How Has This Been Tested?

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@char0n char0n self-assigned this Dec 9, 2020
@char0n char0n self-requested a review December 9, 2020 14:55
@char0n char0n added this to the M12 milestone Dec 9, 2020
@char0n
Copy link
Contributor

char0n commented Dec 9, 2020

More context: immutable-js/immutable-js#667

Copy link
Contributor

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legit! Thank you for contributing!

@char0n char0n merged commit 20a8987 into swagger-api:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants