Multiple values for array type parameters as separated lines in the textarea #1121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extarea. Improved required parameter handling for the array type. Improved default value handling for the array type.
Contributor
|
@valdemon - thank you for the PR, but all PRs should be submitted against the develop_2.0 branch. |
This was referenced Apr 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This addresses eg. the #982 and #987 and likely some others around the subject.
Except of the multi-line text area for the array type params, I've also got a rid of the 'required' and 'default' attributes of the array type parameters.
Please check the use cases here: https://swagger-test-valdemon.c9.io
The above sample UC additionally cover aspects of required parameters and/or default values in a context of the array type.
The validation error (shown in Swagger UI bottom right) is related to declaring the default value as array for the array type parameter, which doesn't sound like wrong I'd say, according to: http://json-schema.org/latest/json-schema-validation.html#anchor101.
Checking the sample 'swagger.json' against any JSON schema validator succeeds btw.
Best,
Waldek