Skip to content

Conversation

@taoyuan
Copy link

@taoyuan taoyuan commented Feb 24, 2016

No description provided.

@fehguy
Copy link
Contributor

fehguy commented Mar 1, 2016

@bodnia does this look OK from your POV?

@bodnia
Copy link
Contributor

bodnia commented Mar 1, 2016

@fehguy is it an expected behaviour of pressing enter key on parameters inputs?
The issue with inconsistent enter key behaviour used to be fixed: there is a form with inputs (and/or text areas) and when a user presses enter on any of input - the form is sent, which is default form behaviour.
As far as rendering a textarea instead of input in case of formData in not an option (as per comment) so I can move this logic (with small refactoring if you don't mind) into parameter view. @fehguy does this make sense?

@fehguy
Copy link
Contributor

fehguy commented Mar 1, 2016

In this example, the idea was to make the enter key convert the text-entry box so it can be used for multi-line items. If it doesn't make sense we can close it out

@bodnia
Copy link
Contributor

bodnia commented Mar 1, 2016

@fehguy it seems to me that this behaviour may be really confusing: instead of default behaviour - sending form, the user gets the input converted into textarea.

The example works correctly and if this behaviour is really needed then I can move this functionality into appropriate place in code.

@fehguy
Copy link
Contributor

fehguy commented Mar 1, 2016

Sounds good. @taoyuan thanks for the contribution but we're going to pass on merging it.

@fehguy fehguy closed this Mar 1, 2016
@taoyuan
Copy link
Author

taoyuan commented Mar 2, 2016

I am glad to make some contribution. Maybe using ctrl + enter is more appropriate?

@bodnia
Copy link
Contributor

bodnia commented Mar 2, 2016

this looks good to me, then we could add a note above the field 'press ctrl + enter to make multiline'. @fehguy does this make sense?

@fehguy
Copy link
Contributor

fehguy commented Mar 4, 2016

@taoyuan please send a new PR if you'd like to pursue that.

@taoyuan
Copy link
Author

taoyuan commented Mar 5, 2016

@fehguy @bodnia I have sent a new PR #2015 to allow ctrl + enter pressed to make multiline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants