Skip to content

Conversation

@owenconti
Copy link
Contributor

Fixes #3473
Remove default of opening links in new tab in markdown content

@webron
Copy link
Contributor

webron commented Aug 1, 2017

@owenconti The opening of links in a new tab is the expected behavior. #3473 is talking about something a bit different - local links should not open in new tabs - that is, other anchors in the same instance of swagger-ui, should just jump to those anchors. However, I'm not sure our markdown parser generates those anchors in the first place, making this a harder problem to solve.

@owenconti
Copy link
Contributor Author

@webron Wouldn't it be more user friendly if we gave the user the choice of opening in a new tab or not? If we do that, we can handle the local links without any issue.

@webron
Copy link
Contributor

webron commented Aug 1, 2017

Even if we do, there's a difference between local links and external ones. It never makes sense for local links to open in an external tab.

As for external links - we used to open them in the same tab, but due to (very) popular demand, implemented the opening in a new tab. It makes sense - if you navigate away from the documentation every time, it can break the flow.

@owenconti
Copy link
Contributor Author

I don't see how we can solve/add local links unless we remove the automatic addition of _target="blank" to all of the links in Markdown content.

Closing this PR.

@owenconti owenconti closed this Aug 1, 2017
@owenconti owenconti deleted the bug/3473-links-open-in-new-tab branch August 1, 2017 23:24
@owenconti owenconti restored the bug/3473-links-open-in-new-tab branch September 8, 2017 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants