Removed animation as temporary fix #3522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shockey So basically the component we are using for the accordion animations take the height of the container and sets it so that it can use css to animate the height property. Now that we have an accordion within an accordion, when the 2nd accordion expands the height of the outer one updates without the animation causing that glitch look. I temporally removed the animation since thats the easiest fix right now. We ran into this same issue with the operations inside the paths accordions.
I noticed that the callbacks accordion is basically the operations component. If we can set a property on that one to remove the animation then we can keep the main operations component animation, but just have the callbacks pop open when clicked sans animation.
for #3450