Skip to content

Conversation

@heldersepu
Copy link
Contributor

@heldersepu heldersepu commented Mar 11, 2018

Description

Add a button to copy response to clipboard

Motivation and Context

Fixes #4300
I like the idea of a button to copy the response to the clipboard, this PR gets the ball rolling...
Still needs improvement on the image/icon used on the button
Use the GitHub icon to copy to clipboard

How Has This Been Tested?

Manual run

Screenshots (if appropriate):

image

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@shockey
Copy link
Contributor

shockey commented Mar 23, 2018

An update here: I've run this up the flagpole for a UX review 😄

@heldersepu
Copy link
Contributor Author

Closing this PR...
Very old never got any traction and there is a new one (#5278) that does not have the unresolved conflicts this one has.

@heldersepu heldersepu closed this Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: copy response to clipboard

2 participants