Skip to content

Conversation

@heldersepu
Copy link
Contributor

@heldersepu heldersepu commented May 3, 2018

Description

Fix #4446

How Has This Been Tested?

Who needs to test when the fix is so simple

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, ..., etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@heldersepu heldersepu changed the title Patch 9 improve downloadable HighlightCode filename (no more response.txt) May 3, 2018
@heldersepu heldersepu changed the title improve downloadable HighlightCode filename (no more response.txt) Improve downloadable HighlightCode filename May 3, 2018
@webron webron requested a review from shockey May 3, 2018 22:20
@shockey shockey added this to the May 4, 2018 milestone May 3, 2018
Copy link
Contributor

@shockey shockey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a few tweaks.

@shockey shockey merged commit 8055129 into swagger-api:master May 4, 2018
@shockey
Copy link
Contributor

shockey commented May 4, 2018

thanks @heldersepu!

@heldersepu
Copy link
Contributor Author

Bamm, and merged just like that!

@heldersepu heldersepu deleted the patch-9 branch May 4, 2018 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Downloadable HighlightCode forcing file to response.txt

2 participants