Moved reference to throbber.gif to CSS file. #540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fehguy
added a commit
that referenced
this pull request
Aug 25, 2014
Moved reference to throbber.gif to CSS file.
Jonahss
pushed a commit
to eaze/swagger-ui
that referenced
this pull request
Aug 12, 2016
…ence Moved reference to throbber.gif to CSS file.
vincent-zurczak
pushed a commit
to roboconf/swagger-ui
that referenced
this pull request
Aug 18, 2016
…ence Moved reference to throbber.gif to CSS file.
JuanSW18
pushed a commit
to Digital-Paw/digital-paw-swagger-ui
that referenced
this pull request
Aug 23, 2024
…ence Moved reference to throbber.gif to CSS file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a more complex set-up, a
swagger-uipage may be served deeper into the site whereinimg.response_throbbercannot locate../images/throbber.gif, because it simply isn't there.This patch moves the reference to the gif from the
imgtag and into the CSS file. Therefore the image only needs to be located relative to the CSS file, not on the page itself.(This is somewhat related to #470)