Skip to content

Conversation

@pontuswallberg
Copy link
Contributor

Description

Updating webpack config files to use this for globalObject.
For more info: https://webpack.js.org/configuration/output/#outputglobalobject

Motivation and Context

Fixes #6136

How Has This Been Tested?

  • Ran npm run test which all passed
  • Ran npm run dev and tested so the app starts
  • Ran npm run build and it built without error
  • Copied the built files into the node_modules for a Docusaurus project. Then both tried so it works in their dev env and building.

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@tim-lai tim-lai self-assigned this Aug 14, 2020
@tim-lai tim-lai merged commit d0ae61f into swagger-api:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReferenceError: window is not defined

2 participants