Skip to content

Conversation

@Saibamen
Copy link
Contributor

@Saibamen Saibamen commented Oct 8, 2020

Remove npm install from steps

Description

npm run dev already triggers npm install. No need to do that twice.

Motivation and Context

Saving installation time

How Has This Been Tested?

By executing all steps in setting-up.md

Screenshots (if appropriate):

image

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

Remove `npm install` from steps
@Saibamen Saibamen changed the title Update setting-up.md Remove npm install from steps in setting-up.md Oct 8, 2020
@tim-lai tim-lai merged commit 5fc43fa into swagger-api:master Oct 15, 2020
@tim-lai
Copy link
Contributor

tim-lai commented Oct 15, 2020

@Saibamen Merged! Thanks for the contribution!

@Saibamen Saibamen deleted the patch-3 branch October 15, 2020 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants