Skip to content

fix(view-plugin): provide resolvers for memoized functions #7801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2022
Merged

fix(view-plugin): provide resolvers for memoized functions #7801

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f66337
fix(view-plugin): provide resolvers for memoized functions
char0n Jan 26, 2022
084fdae
fix: mapped container
char0n Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/core/plugins/view/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,22 @@ import { memoize } from "core/utils"

import { getComponent, render, withMappedContainer } from "./root-injects"
import { getDisplayName } from "./fn"
import memoizeN from "../../../helpers/memoizeN"

const memoizeForGetComponent = (fn) => {
const resolver = (...args) => JSON.stringify(args)
return memoize(fn, resolver)
}

const memoizeForWithMappedContainer = (fn) => {
const resolver = (...args) => args
return memoizeN(fn, resolver)
}

const viewPlugin = ({getComponents, getStore, getSystem}) => {
// getComponent should be passed into makeMappedContainer, _already_ memoized... otherwise we have a big performance hit ( think, really big )
const memGetComponent = memoize(getComponent(getSystem, getStore, getComponents))
const memMakeMappedContainer = memoize(withMappedContainer(getSystem, getStore, memGetComponent))
const memGetComponent = memoizeForGetComponent(getComponent(getSystem, getStore, getComponents))
const memMakeMappedContainer = memoizeForWithMappedContainer(withMappedContainer(getSystem, getStore, memGetComponent))

return {
rootInjects: {
Expand Down