Merged
Conversation
AccessPlanner previously walked the full aggregate DIE subtree when resolving a member chain. That let members of nested C++ types match as if they were direct members of the parent aggregate, so invalid accesses such as `o.shadow` could compile instead of failing. Switch member lookup to direct DW_TAG_member children only, and add an e2e regression that accepts `o.nested.shadow` while rejecting `o.shadow`.
Stop DWARF expression parsing from returning values when a valid prefix is followed by an invalid or unsupported operation. Make CFI expression parsing reject unsupported opcodes instead of skipping them, so traces fail rather than using partial compute steps. Add unit coverage for both DWARF and CFI fail-open regressions.
swananan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.