fix: carry DWARF module origin in read plans#180
Merged
Conversation
Global variable planning returned the resolved module path, but the compiler stored it in mutable context state and consumed it later during lowering. DWARF queries used only for type checks could leave stale hints behind, so later ASLR rebasing could use the wrong module for cross-module globals. Store the module origin directly on read and materialization plans instead. Populate it in PC and global analyzers, and make compiler lowering use that explicit origin when converting link-time addresses to runtime addresses. Carry the same origin through dynamic array and member lowering so type completion for unknown aggregate targets is scoped to the module that owns the base variable. Add a globals e2e regression with conflicting same-name struct layouts in the main executable and shared library. The test exercises dynamic member access through a shared-library global pointer and catches fallback to the current probe module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Global variable planning returned the resolved module path, but the compiler stored it in mutable context state and consumed it later during lowering. DWARF queries used only for type checks could leave stale hints behind, so later ASLR rebasing could use the wrong module for cross-module globals.
Store the module origin directly on read and materialization plans instead. Populate it in PC and global analyzers, and make compiler lowering use that explicit origin when converting link-time addresses to runtime addresses. Carry the same origin through dynamic array and member lowering so type completion for unknown aggregate targets is scoped to the module that owns the base variable.
Add a globals e2e regression with conflicting same-name struct layouts in the main executable and shared library. The test exercises dynamic member access through a shared-library global pointer and catches fallback to the current probe module.