test: make entry value runtime log dirs unique#196
Merged
Conversation
Use a process-local atomic sequence in addition to the timestamp because container e2e tests can create runtime log directories concurrently with identical clock values. This avoids failing the helper with File exists when the tests race under CI. The tradeoff is a small process-local counter and a bounded retry loop on EEXIST. Directory names become longer, but cleanup and target log behavior stay unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a process-local atomic sequence in addition to the timestamp because container e2e tests can create runtime log directories concurrently with identical clock values. This avoids failing the helper with File exists when the tests race under CI.
The tradeoff is a small process-local counter and a bounded retry loop on EEXIST. Directory names become longer, but cleanup and target log behavior stay unchanged.