feat(ctrl): PSBT signing for BTC via sats-connect (V3 flow)#12
Merged
feat(ctrl): PSBT signing for BTC via sats-connect (V3 flow)#12
Conversation
Wire window.ctrl.bitcoin's sign_psbt RPC into a toolbox signer so
getUtxoToolbox(Chain.Bitcoin, { signer }) synthesizes
signAndBroadcastTransaction, unblocking the V3 SwapKit swap plugin for
CTRL Bitcoin. BCH/DOGE/LTC remain on the bespoke walletTransfer path
since CTRL only exposes sats-connect for BTC.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
The V3 SwapKit plugin calls `wallet.signAndBroadcastTransaction(psbtTransaction)`. That method is synthesized by `getUtxoToolbox` only when a `{ signer }` is passed at construction. CTRL's current BTC path calls `getUtxoToolbox(chain)` with no signer and only overrides `transfer`, so the plugin's V3 path breaks. This PR matches the pattern already used by Phantom / OKX / BITGET / ONEKEY / PASSKEYS.
Notes
Test plan
🤖 Generated with Claude Code