feat(okx): pass offline signer to Cosmos toolbox (V3 flow)#13
Merged
feat(okx): pass offline signer to Cosmos toolbox (V3 flow)#13
Conversation
OKX already builds a Keplr-compatible OfflineAminoSigner via wallet.getOfflineSignerOnlyAmino(chainId); it just wasn't being passed into getCosmosToolbox. Wiring it in lets the toolbox synthesize signAndBroadcastTransaction, which the V3 SwapKit plugin calls. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One-line fix: the OKX Cosmos path already builds a Keplr-compatible `OfflineAminoSigner` via `wallet.getOfflineSignerOnlyAmino(chainId)`, but never hands it to `getCosmosToolbox`. Passing it in lets the toolbox synthesize `signAndBroadcastTransaction`, which the V3 SwapKit plugin calls.
Why
The V3 plugin invokes `wallet.signAndBroadcastTransaction(cosmosTx)`. That method is only exposed when the toolbox is constructed with a signer. Without it, OKX Cosmos silently falls back to the bespoke `transfer` helper and V3 swaps fail.
Test plan
🤖 Generated with Claude Code