feat(bitget): wire real signers for Cosmos + Solana (V3 flow)#14
Merged
feat(bitget): wire real signers for Cosmos + Solana (V3 flow)#14
Conversation
Cosmos: drop the dead `signTransaction: async () => ({} as any)` stub
and use Object.assign so the toolbox's V3 signAndBroadcastTransaction can
reach the real signAmino/getAccounts on the OfflineAminoSigner BitGet
already returns.
Solana: stop spreading the provider — Object.assign keeps signTransaction
and signAndSendTransaction bound to the provider instance so the toolbox
can call them with VersionedTransaction.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
getOfflineSignerAuto returns OfflineDirectSigner on hot wallets and falls back to OfflineAminoSigner on Ledger — V3's proto SignDoc path signs natively without amino downconversion. Also extend the bitkeep.keplr type with getOfflineSignerAuto + OfflineDirectSigner import. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The V3 SwapKit plugin invokes `wallet.signAndBroadcastTransaction(payload)`. The Cosmos / Solana toolboxes synthesize that method on top of the signer's primitives. Today:
Notes
Amino-only signer is sufficient — V3 swaps on Cosmos Hub use `MsgSend` / IBC `MsgTransfer`, both amino-safe. We can swap to dual signer later if a CosmWasm-bound chain comes in.
Test plan
🤖 Generated with Claude Code